Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add hugepages info to attributes #1924

Merged
merged 1 commit into from
Aug 17, 2020
Merged

add hugepages info to attributes #1924

merged 1 commit into from
Aug 17, 2020

Conversation

tianshapjq
Copy link
Contributor

@tianshapjq tianshapjq commented Apr 9, 2018 •
edited
Loading

the hugepages info in "/attributes" should be equal to "/machine"

@k8s-ci-robot
Copy link
Collaborator

Hi @tianshapjq. Thanks for your PR.

I'm waiting for a kubernetes or google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tianshapjq
Copy link
Contributor Author

@mindprince I found these mismatches in these two api, could you please verify this?

@rohitagarwal003
Copy link
Contributor

cc @derekwaynecarr

@tianshapjq
Copy link
Contributor Author

@derekwaynecarr is this acceptable?

@dashpole
Copy link
Collaborator

/ok-to-test

odinuge
odinuge approved these changes Aug 16, 2020
View reviewed changes
Copy link
Contributor

@odinuge odinuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

ping @dashpole

@k8s-ci-robot
Copy link
Collaborator

@odinuge: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/lgtm
/retest

ping @dashpole

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dashpole dashpole assigned dashpole and unassigned derekwaynecarr Aug 17, 2020
dashpole
dashpole approved these changes Aug 17, 2020
View reviewed changes
Copy link
Collaborator

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dashpole dashpole merged commit 7ec5180 into google:master Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

@odinuge odinuge odinuge approved these changes

Assignees

@dashpole dashpole

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tianshapjq @k8s-ci-robot @rohitagarwal003 @dashpole @odinuge @derekwaynecarr